Do not issue warning if cannot parse _task entity #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted docstring to note that now _task- can be used in many other modalities
❯ git grep -l -B4 -E 'task: (r|o)'
src/schema/README.md
src/schema/rules/files/raw/anat.yaml
src/schema/rules/files/raw/beh.yaml
src/schema/rules/files/raw/channels.yaml
src/schema/rules/files/raw/eeg.yaml
src/schema/rules/files/raw/func.yaml
src/schema/rules/files/raw/ieeg.yaml
src/schema/rules/files/raw/meg.yaml
src/schema/rules/files/raw/nirs.yaml
src/schema/rules/files/raw/pet.yaml
src/schema/rules/files/raw/task.yaml
and overall -- even if required for some modality (e.g. func) IMHO we should
not redo bids-validator functionality here. It should be validator to report
oddities (may be we should bolt on integration with basic validation present in
bidsschematools).
Codecov ReportBase: 81.29% // Head: 81.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 81.29% 81.28% -0.01%
==========================================
Files 41 41
Lines 3817 3816 -1
==========================================
- Hits 3103 3102 -1
Misses 714 714
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjusted docstring to note that now _task- can be used in many other modalities
and overall -- even if required for some modality (e.g. func) IMHO we should not redo bids-validator functionality here. It should be validator to report oddities (may be we should bolt on integration with basic validation present in bidsschematools).
Closes #613