BF(?): make _setter images be taken as scouts - only DICOMs are saved #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
766c446 to
8f81914
Compare
8f81914 to
9e299e3
Compare
|
rebased, force pushed with hope to CI run now |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 41 41
Lines 4117 4117
=======================================
Hits 3371 3371
Misses 746 746
☔ View full report in Codecov by Sentry. |
9e299e3 to
409e6bb
Compare
|
have not got any feedback, and will just assume that it would all work ;) we are at v0.12.2-93-g409e6bb so it is really a time to release. |
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to fix #40
@cookpa @tsalo -- may be such approach would be sufficient (i.e. would not cause some disturbance as e.g. not saving DICOM tarballs correctly for T1w)? Would you be so kind to try on your data?
edit: an alternative -- completely ignore/skip them