Set up auto #558
Set up auto #558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 81.24% 81.26% +0.01%
==========================================
Files 41 41
Lines 3813 3817 +4
==========================================
+ Hits 3098 3102 +4
Misses 715 715
Continue to review full report at Codecov.
|
|
Re docker:
|
|
@yarikoptic Dockerization added. |
There was a problem hiding this comment.
may be to add some CONTRIBUTING.md with brief description of this release process, and what to do if it doesn't work out, i.e. is there a way to at least introduce version adjustments?
but also I thought if it would be possible to add versioneer or your versioningit while at it , or it better be a separate PR? I am tired of --version to be not git informed in heudiconv.
.github/workflows/release.yml
Outdated
| id: latest-release | ||
| run: | | ||
| latest_tag="$(curl -fsSL https://api.github.com/repos/$GITHUB_REPOSITORY/releases/latest | jq -r .tag_name)" | ||
| echo "::set-output name=tag::$latest_tag" |
There was a problem hiding this comment.
why needs.auto-release.outputs.auto-version can't be used here? I am afraid if api.github has some delay in propagating effects of auto shipit we might end up using some wrong tag here.
There was a problem hiding this comment.
Because auto version outputs a patch level, not a version number.
There was a problem hiding this comment.
I feel that we had similar problem somewhere else and did find how to trick auto to tell us the full version, didn't we? I would really prefer to not rely on the logic of jumping through github without any validation that the tag does correspond to this state. Wouldn't prior step tag it, so we could just use git describe here and get a clean version?
|
|
||
| prep_release: | ||
| # take previous one, and replace with the next one | ||
| utils/prep_release |
There was a problem hiding this comment.
if github workflow fails somehow, how could we prep release locally? i.e. how at least bumpversion would be done?
I wonder if either Makefile or some documentation should be left behind on that.
If we use versioningit, then presumably we would want to get rid of all the explicit version numbers bumped by
|
|
All of the above sounds good to me. Yes, singularity should pull from docker hub, we will provide also images from ///repronim/containers later |
|
@yarikoptic versioningit added; bump2version eliminated. |
|
ok, let's proceed and see where it takes us |
|
🚀 PR was released in |
Closes #557.
This PR also needs to be accompanied by the following changes:
autoby runningGH_TOKEN=... auto create-labelsin a copy of this repository containing.autorcheudiconvproject to PyPI must be saved as a secret named "PYPI_TOKEN"nipy/heudiconvimages must be saved as secrets namedDOCKER_LOGINandDOCKER_TOKEN, respectively (@yarikoptic is waiting for repronimservices to be added to the team to be used heredid for another account)