BF(TST): use caplog instead of capfd for testing if we log a warning #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason on my laptop capfd failed to provide desired effect. May be because I am running pytest with -s ;) will not investigate -- using caplog is the more kosher way for this purpose, and allows for control of the logging level we would like to have to ensure that the message is output
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 77.63% 77.64%
=======================================
Files 41 41
Lines 3166 3167 +1
=======================================
+ Hits 2458 2459 +1
Misses 708 708
Continue to review full report at Codecov.
|
|
ok, it is all green and now should be green not only for Travis but also for me -- "win/win", let's proceed |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason on my laptop capfd failed to provide desired effect. May be because
I am running pytest with -s ;) will not investigate -- using caplog is the more
kosher way for this purpose, and allows for control of the logging level we would like
to have to ensure that the message is output