Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis - Use bionic for the base #533

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Conversation

yarikoptic
Copy link
Member

we were still using 16.04. For that one we do not even have newer dcm2niix
in NeuroDebian: http://neuro.debian.net/pkgs/dcm2niix.html

With older version test_b0dwi_for_fmap passes (on travis) but I see it
failing locally, so want to see what happens on Travis

we were still using 16.04.  For that one we do not even have newer dcm2niix
in NeuroDebian: http://neuro.debian.net/pkgs/dcm2niix.html

With older version test_b0dwi_for_fmap passes (on travis) but I see it
failing locally, so want to see what happens on Travis
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #533 (75b4868) into master (c4956b3) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   77.55%   77.63%   +0.08%     
==========================================
  Files          41       41              
  Lines        3154     3166      +12     
==========================================
+ Hits         2446     2458      +12     
  Misses        708      708              
Impacted Files Coverage Δ
heudiconv/tests/test_heuristics.py 100.00% <0.00%> (ø)
heudiconv/bids.py 84.61% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4956b3...75b4868. Read the comment docs.

@yarikoptic
Copy link
Member Author

hm, ok -- we have newer dcm2niix

Get:5 http://neuro.debian.net/debian bionic/main amd64 dcm2niix amd64 1:1.0.20211006-1~nd18.04+1 [224 kB]

and test still passes -- so must be something else about my local environment. Let's proceed with the CI upgrade to bionic then as is

@yarikoptic yarikoptic merged commit 8d85f14 into nipy:master Oct 28, 2021
@yarikoptic yarikoptic deleted the rf-newer-travis branch October 28, 2021 19:06
@yarikoptic yarikoptic added the tests Add or improve existing tests label Apr 20, 2022
@github-actions
Copy link

🚀 PR was released in v0.11.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant