ENH: Default to 4mm re-zoom for b-spline approximation #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6de9fbe to
c0d834c
Compare
|
This was discussed in meeting. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downsample fieldmap images to 4mm isotropic before approximating b-splines.
The 1.95mm suggestion was a cut-off for downsampling by a factor of 2 so that we did not go worse than 4mm. (The 0.05 margin was to avoid something like 1.99x1.99x2.01 from becoming 3.98x3.98x2.01.) Given that instead we're resampling to a maximum resolution, let's just set it
Running at 2mm, I'm still finding multi-hour approximations. 4mm seems reasonable, as that's still a 4:1 voxels-to-knots ratio for the high-frequency components. I haven't tried 3mm.