ENH: Allow bids filtering during get() calls.
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by #293 |
This is to bring SDCFlow's file filtering more in-line with approaches taken in other nipreps. To avoid potential collisions during `get()` parameter assigment, base / additional values are first merged into a dictionary, and then passed in as keyword arguments
b909a8d to
30f5ae2
Compare
Codecov ReportBase: 85.38% // Head: 87.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 85.38% 87.22% +1.83%
==========================================
Files 24 25 +1
Lines 1930 1988 +58
Branches 221 299 +78
==========================================
+ Hits 1648 1734 +86
+ Misses 246 220 -26
+ Partials 36 34 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
approved these changes
Oct 21, 2022
|
It looks like we've had a bunch of significant changes since 2.1.1, so |
|
Can backport if needed. |
effigies
pushed a commit
to effigies/sdcflows
that referenced
this pull request
Dec 7, 2022
This is to bring SDCFlow's file filtering more in-line with approaches taken in other nipreps. To avoid potential collisions during `get()` parameter assigment, base / additional values are first merged into a dictionary, and then passed in as keyword arguments Backport niprepsgh-292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to bring SDCFlow's file filtering more in-line with approaches taken in other nipreps. To avoid potential collisions during
get()parameter assigment, base / additional values are first merged into a dictionary, and then passed in as keyword arguments