Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Loosen installation restrictions #269

Merged
merged 3 commits into from
May 13, 2022

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented May 2, 2022

Since sdcflows is nipreps middleware and will be used by various tools, we should not be overtly strict on installations.

@mgxd mgxd force-pushed the maint/loosen-deps branch from 9e4f4cf to 24b87b6 Compare May 2, 2022 18:39
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #269 (913aec2) into master (56a02bf) will increase coverage by 4.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   83.09%   87.35%   +4.26%     
==========================================
  Files          25       25              
  Lines        1851     1851              
  Branches      278      278              
==========================================
+ Hits         1538     1617      +79     
+ Misses        281      204      -77     
+ Partials       32       30       -2     
Flag Coverage Δ
travis 83.09% <ø> (ø)
unittests 87.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/workflows/outputs.py 93.54% <0.00%> (+1.61%) ⬆️
sdcflows/interfaces/reportlets.py 89.83% <0.00%> (+1.69%) ⬆️
sdcflows/interfaces/bspline.py 87.44% <0.00%> (+4.18%) ⬆️
sdcflows/interfaces/fmap.py 87.35% <0.00%> (+14.94%) ⬆️
sdcflows/workflows/fit/syn.py 69.82% <0.00%> (+21.30%) ⬆️
sdcflows/utils/phasemanip.py 94.02% <0.00%> (+28.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a02bf...913aec2. Read the comment docs.

@mgxd
Copy link
Contributor Author

mgxd commented May 3, 2022

i'm not sure why pypy is installed and not cpython... is this just a case of the cache needing to be cleared?

@effigies
Copy link
Member

effigies commented May 5, 2022

We had this issue a couple weeks ago with niworkflows or something. I think the conda-forge builds of Python are now treating cpython and pypy as variant builds of Python, and pypy is lexically later than cpython so is seen as more recent by the resolver.

Sometimes.

@mgxd mgxd force-pushed the maint/loosen-deps branch from 0624222 to 983be48 Compare May 5, 2022 15:27
@mgxd mgxd force-pushed the maint/loosen-deps branch from cfbbf2c to 167edcf Compare May 5, 2022 16:18
@mgxd
Copy link
Contributor Author

mgxd commented May 13, 2022

I guess clearing the cache worked... good to merge?

@mgxd mgxd requested review from oesteban and effigies and removed request for oesteban May 13, 2022 14:48
@effigies effigies merged commit d245dfd into nipreps:master May 13, 2022
@effigies
Copy link
Member

We'll see.

@mgxd mgxd deleted the maint/loosen-deps branch May 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants