Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] MagneticFieldStrength should be float #45

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Jan 8, 2019

No description provided.

@chrisgorgo chrisgorgo merged commit aa56113 into master Jan 11, 2019
@chrisgorgo
Copy link
Contributor

@rwblair could you deploy? Thanks!

@oesteban oesteban deleted the oesteban-patch-1 branch January 11, 2019 21:06
@oesteban
Copy link
Member Author

oesteban commented Jan 11, 2019

We should also correct old entries, right? This should minimize errors:

  • s/1/1.5/g
  • s/2/2.95/g

(we will probably push some 1T to 1.5T, but I'd say most of the records are 1.5T)

@chrisgorgo
Copy link
Contributor

This would better be done in data cleaning: https://www.kaggle.com/chrisfilo/mriqc-data-cleaning

@rwblair
Copy link
Contributor

rwblair commented Jan 16, 2019

@chrisfilo sorry for the delay, latest master should be up now on the server.

@chrisgorgo
Copy link
Contributor

chrisgorgo commented Jan 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants