MAINT: Finalize the work we started with the refactor of the Docker image #2601
Conversation
| @@ -51,7 +48,6 @@ packages = find: | |||
| [options.extras_require] | |||
| datalad = datalad | |||
| doc = | |||
| nbsphinx | |||
There was a problem hiding this comment.
I left nbsphinx as an extension - but we don't have any notebooks to render. So I removed it there.
| nitransforms ~= 21.0.0 | ||
| niworkflows ~= 1.4.1 | ||
| niworkflows @ git+https://github.com/nipreps/niworkflows.git@master |
There was a problem hiding this comment.
I may have missed/forgotten a conversation. Is the to only pin at release?
There was a problem hiding this comment.
IMO it helps us catch any potential problems sooner.
There was a problem hiding this comment.
K. I assume this will change to maint/1.4.x once that diverges from master?
There was a problem hiding this comment.
We didn't get that far in the discussion, but yes, I guess that for maint/20.2.x and so on should pin the corresponding maintenance lines of niworkflows and sdcflows.
There was a problem hiding this comment.
This is why we relaxed the packaging tests to only exercise rel/* and tags, right?
Builds on top of #2581 with the following additions:
nipreps/miniconda:py38_1.3.2which has an almost complete environment set-up for fMRIPrep and dMRIPrep. Builds now should not need to download many packages.Hopefully, a first step towards the smooth transition into these multi-staged builds.