-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Tedana-friendly ME derivatives #2575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcf473c
to
db6bb74
Compare
1a40ec3
to
e7da420
Compare
e7da420
to
831a35d
Compare
068726b
to
ccb422f
Compare
Need to update the expected derivatives for ds000210 and do a style pass, but otherwise I think this is ready for review. Definitely did some quick-and-dirty patches to get all of the metadata in, which could stand some thoughtful cleaning up. |
oesteban
approved these changes
Oct 31, 2021
Co-authored-by: Oscar Esteban <code@oscaresteban.es>
11a85a5
to
1e750f0
Compare
This is ready and can either go in 21.0.0 or wait for the next series. |
My vote goes to 21.0.0, FWIW 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
--output-echos
flag to indicate that BOLD series should be output for individual echos.TODO:
Beginning to address #2542.
Builds on #2574.
Documentation that should be reviewed