Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Tedana-friendly ME derivatives #2575

Merged
merged 9 commits into from
Nov 5, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 5, 2021

Changes proposed in this pull request

  • Add --output-echos flag to indicate that BOLD series should be output for individual echos.

TODO:

  • Figure out what's going on with SDC. Currently all the logic is in a branch that assumes no SDC.
  • ...

Beginning to address #2542.
Builds on #2574.

Documentation that should be reviewed

@effigies effigies force-pushed the enh/me_derivatives branch from fcf473c to db6bb74 Compare October 7, 2021 12:38
@pep8speaks
Copy link

pep8speaks commented Oct 29, 2021

Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-01 19:12:09 UTC

@effigies
Copy link
Member Author

Need to update the expected derivatives for ds000210 and do a style pass, but otherwise I think this is ready for review. Definitely did some quick-and-dirty patches to get all of the metadata in, which could stand some thoughtful cleaning up.

@effigies effigies requested a review from mgxd October 29, 2021 20:57
@effigies effigies marked this pull request as ready for review November 1, 2021 00:54
@effigies
Copy link
Member Author

effigies commented Nov 2, 2021

This is ready and can either go in 21.0.0 or wait for the next series.

@effigies effigies added this to the 21.0.0 milestone Nov 2, 2021
@oesteban
Copy link
Member

oesteban commented Nov 2, 2021

My vote goes to 21.0.0, FWIW 👍

@effigies effigies merged commit ebeaf90 into nipreps:master Nov 5, 2021
@effigies effigies deleted the enh/me_derivatives branch November 5, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants