FIX: --slice-time-ref option parsing #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With pytest passing, I'm comfortable asking for a review. |
mgxd
approved these changes
Oct 5, 2021
| @@ -5,7 +5,7 @@ | |||
| from .. import config | |||
|
|
|||
|
|
|||
| def _build_parser(): | |||
| def _build_parser(**kwargs): | |||
There was a problem hiding this comment.
Maybe add a docstring line stating kwargs are intended for argparse.ArgumentParser?
|
Merged quickly to avoid wasting time on CI. Probably should have put a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
**kwargsto _build_parser() to allow us to pass arguments that can be used for debugging--slice-time-ref--slice-time-refFixes #2572.
Documentation that should be reviewed