-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Refactor workflow to adopt *SDCFlows*' new correction workflow #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
added a commit
to oesteban/fmriprep
that referenced
this pull request
Sep 22, 2021
oesteban
added a commit
that referenced
this pull request
Sep 22, 2021
STY: Run black on ``workflows.bold.base`` to clarify diff in #2547
**multi-echo not yet covered!!!!**
87addcf
to
a4526c9
Compare
@mgxd I've rebased on master after running black on |
This is holding me up a little, so I'll merge. |
This was referenced Oct 4, 2021
oesteban
added a commit
that referenced
this pull request
Oct 7, 2021
This PR builds on top of #2547, unifying the final BOLDref computation.
oesteban
added a commit
to effigies/fmriprep
that referenced
this pull request
Oct 18, 2021
This PR builds on top of nipreps#2547, unifying the final BOLDref computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem reported in #2210.
Along with the specific changes in SDCFlows, this PR:
IdentityInterface
node calledbold_final
that acts as buffer to reduce LoC and branches when dealing with data with/without fieldmaps (and helpful too for ME-EPI, although this is not fully implemented).RobustAverage
node, therefore fixing one issue reported in Susceptibility distortion correction (SDC) using Spin Echo Fieldmaps #2210.bold_final
node, which contains HMC'ed + SDC'ed (if fieldmaps found) BOLD in native space. Now, it is matched with the ROIs plot, reducing a little the opportunities for divergence.This PR DOES NOT solve (or even leaves without implementation):
B0FieldTransform
botches the displacements field with flipped axes sdcflows#236)