Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add flag for STC reference time and set in all cases #2520
ENH: Add flag for STC reference time and set in all cases #2520
Changes from 3 commits
c8d2636
27d0b88
f921ab9
8756d01
a63a1bc
322da0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the example in lines 69/70 (2s TR, 0-0.9), this would then yield an offset of 0.45, correct? I think that printing/logging this as an output rather than the intended time offset (1s) may be a bit confusing. I'd opt for printing/logging the intended time offset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what you mean by the "intended time offset" here. The default 3dTshift behavior sets
tzero
to the middle of the acquisition time (0.45), as does the proposed default behavior here. I'm not sure under what circumstances you would expect to see 1s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not being clearer! The point was that it would perhaps be easier for users to know what the temporal offset is not in terms of percent but in terms of time. Else they might be confused that putting in 0.5 for a TR of 2s returns 0.45 and not 1s. Hope that’s clearer?