DOC: Update sample report #2519
Conversation
.zenodo.json
Outdated
| @@ -271,6 +271,10 @@ | |||
| "name": "Blair, Ross W.", | |||
| "orcid": "0000-0003-3007-1056" | |||
| }, | |||
| { | |||
| "affiliation": "Department of Radiology, University Hospital of Lausanne and University of Lausanne", | |||
| "name": "Provins, Céline", | |||
There was a problem hiding this comment.
Please, add yourself to .maint/contributors.json instead.
Other than that, this looks great 👍 thanks!
There was a problem hiding this comment.
Ok. Should I remove myself from the zenodo.json as well ?
It might be worth changing the pull request template, because I added myself in the zenodo.json following the indications for new contributors written in the pull request template.
There was a problem hiding this comment.
Yes, that would be cleaner. Before every release, we update the zenodo file pulling from the jsons under .maint/ so your name will be inserted at that time.
.maint/contributors.json
Outdated
| @@ -199,5 +199,10 @@ | |||
| "affiliation": "State Key Laboratory of Cognitive Neuroscience and Learning, Beijing Normal University", | |||
| "name": "Ye, Zhifang", | |||
| "orcid": "0000-0003-0489-2619" | |||
| }, | |||
| { | |||
| "affiliation": "Department of Radiology, University Hospital of Lausanne", | |||
There was a problem hiding this comment.
| "affiliation": "Department of Radiology, University Hospital of Lausanne", | |
| "affiliation": "Department of Radiology, Lausanne University Hospital and University of Lausanne", |
.maint/contributors.json
Outdated
| { | ||
| "affiliation": "Department of Radiology, University Hospital of Lausanne", | ||
| "name": "Provins, Céline", | ||
| "orcid":"" |
There was a problem hiding this comment.
Can you make yourself an ORCID and update here? - https://orcid.org/register
.maint/contributors.json
Outdated
| }, | ||
| { | ||
| "affiliation": "Department of Radiology, University Hospital of Lausanne", | ||
| "name": "Provins, Céline", |
There was a problem hiding this comment.
Names are ordered alphabetically (through the lastname), please move up to the right position.
Changes proposed in this pull request
Closes #1858
Documentation that should be reviewed