PIN: NiPreps dependencies to development branches #2380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oesteban was niworkflows 1.4.0rc5 released from a yet-to-be pushed branch? |
|
Oh yes, I need to merge |
|
right...forgot about the dreaded sdcflows 2.0 migration... |
|
Should we just close this one and use link dependencies only during testing PRs? |
|
I still think there's some merit to pinning the closely related nipreps packages to master. |
oesteban
approved these changes
Jul 19, 2021
|
I don't think we can use dependency links for niworkflows and sdcflows before #2392 is merged. Why don't we just merge the changes to CircleCI's config here and update the dependencies there? |
|
Totally agree - opened #2472 in favor of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned after discussion with @oesteban in #2372 (comment)