-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: skull stripping is forced by default #2345
Conversation
docs say that the heuristic is used by default but at the moment skull stripping is forced nipreps#2318, updated docs to mention this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! Left one minor suggestion.
Would you like to add yourself as a contributor to the .zenodo.json
file?
Sure! Just did, thanks |
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Two small style suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this contribution, I left a few nit picks.
docs/workflows.rst
Outdated
T1w image is already masked. This must be explicitly requested with | ||
``---skull-strip-t1w auto``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T1w image is already masked. This must be explicitly requested with | |
``---skull-strip-t1w auto``. | |
T1w image is already masked. | |
This may be explicitly requested with ``---skull-strip-t1w auto``. |
Easier to see diffs when new sentences start with new line.
ha I should've refreshed the tab before commenting :D |
fix linebreaks Co-authored-by: Chris Markiewicz <effigies@gmail.com>
fix wording Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Ok, incorporated those changes! |
Great, thanks! |
Changes proposed in this pull request
docs say that the deteciton heuristic is used by default but at the moment skull stripping is forced per #2318, updated docs to mention this