FIX: Generate proper LTA transform prior BOLD sampling on surfaces #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary patch before we go all the way in with NiTransforms in the sampling of BOLD on surfaces. The anatomical _fast-track_ required to expose the fsnative-to-T1w transform in the derivatives folder (which we were already doing in ITK format). When fMRIPrep ran without the fast-track, then the LTA transform would be directly passed in without conversions. The fast-track PR forced the implementation to use the ITK version. This, in conjunction with the little trick to stick the BOLD shape and zooms into the LTA (i.e., using ``lta_concatenate`` with an identity transform with those features, shape and zooms, as moving) resulted in an overly complex workflow that I partially implemented with NiTransforms. This PR gets rid of the concatenation with identity trick, using NiTransforms to generate a transform equivalent to the concatenated LTA we used to generate before the fast-track was introduced. Resolves: nipreps#2145 Assign: @mgxd Milestone: 20.1.0 Related: nipreps#2118, nipreps#2041, nipreps#2121.
This comment has been minimized.
This comment has been minimized.
effigies
reviewed
May 27, 2020
effigies
reviewed
May 27, 2020
|
testing off 1d417a9, surfaces look muuuuch better! |
|
Good to go? |
mgxd
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary patch before we go all the way in with NiTransforms
in the sampling of BOLD on surfaces.
The anatomical fast-track required to expose the fsnative-to-T1w
transform in the derivatives folder (which we were already doing in ITK
format).
When fMRIPrep ran without the fast-track, then the LTA transform would
be directly passed in without conversions. The fast-track PR forced the
implementation to use the ITK version.
This, in conjunction with the little trick to stick the BOLD shape and
zooms into the LTA (i.e., using
lta_concatenatewith an identitytransform with those features, shape and zooms, as moving) resulted in
an overly complex workflow that I partially implemented with
NiTransforms.
This PR gets rid of the concatenation with identity trick, using
NiTransforms to generate a transform equivalent to the concatenated LTA
we used to generate before the fast-track was introduced.
Resolves: #2145
Related: #2118, #2041, #2121.