Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Ensure correct WM and CSF masks are picked in confounds workflow #2128

Merged
merged 1 commit into from
May 21, 2020
Merged

FIX: Ensure correct WM and CSF masks are picked in confounds workflow #2128

merged 1 commit into from
May 21, 2020

Conversation

oesteban
Copy link
Member

@auto-comment

This comment has been minimized.

Sign in to view
@oesteban oesteban force-pushed the fix/smriprep-189 branch from c896f90 to 5d5812d Compare May 20, 2020 16:30
@oesteban oesteban mentioned this pull request May 20, 2020
Closed
4 tasks
@oesteban oesteban added this to the 20.1.0 milestone May 20, 2020
@oesteban oesteban force-pushed the fix/smriprep-189 branch from 5d5812d to dc9fe2c Compare May 20, 2020 23:37
@oesteban
Copy link
Member Author

Hey @mgxd, can you double-check this locally before merging (same you did for the sMRIPrep counterpart).

I have run this on the subject that was failing in #1697 (ds054/sub-100068) and it seems okay. The run condition in my settings is --fs-no-reconall without--anat-derivatives.

@oesteban oesteban requested a review from mgxd May 20, 2020 23:41
@mgxd
Copy link
Collaborator

mgxd commented May 21, 2020

looks fine to me, thanks!

@mgxd mgxd merged commit f63ed2f into nipreps:master May 21, 2020
@oesteban oesteban deleted the fix/smriprep-189 branch September 4, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgxd mgxd Awaiting requested review from mgxd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oesteban @mgxd