MNT: Pin minor series of nipype, major of nibabel #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added a commit
that referenced
this pull request
Mar 11, 2020
Merge notes: * Fix gh-2014 appears to have been made unnecessary by gh-2018. Tag message: 20.0.2 (March 6, 2020) ====================== A bug squashing release in the 20.0.x series. This release fixes the use of custom templates within the docker wrapper, remedies crashes when FreeSurfer HOME was not set, and improves the documentation for local installations. With thanks to Blaise Frederick for the contribution. * DOC: Update standalone installation requirements (#2009) * FIX: Crashes whenever FREESURFER_HOME is not set (#2014) * FIX: Local template mounting (wrapper) (#2020) * MAINT: Pin minor series of nipype, major series of nibabel (#2021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a conversation in nipy/nipype#3180, it seems prudent to pin to minor series of nipype. Nipype is on bug-fix-only patch releases. This fits well with our proposed rules for minor release series. Upgrading the nipype pin to a new minor release series would only be valid in minor releases of fMRIPrep.
I also pinned nibabel 3.0. Nibabel has very strict backwards-compatibility constraints within a major version series, so upgrading to a new minor release should not introduce any concerns even in bug-fix releases.
We might want to consider assessing other dependencies. With the prospect of long-term releases, unpinned dependencies become riskier.