Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN: nilearn!=0.5.0,!=0.5.1 to avoid problems plotting mgz images #1585

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

oesteban
Copy link
Member

No description provided.

@oesteban oesteban requested a review from effigies April 17, 2019 15:24
@oesteban
Copy link
Member Author

I just saw #1584 (comment)

@oesteban oesteban changed the title PIN: nilearn<5.0.0a0 to avoid problems plotting mgz images PIN: nilearn!=0.5.0,!=0.5.1 to avoid problems plotting mgz images Apr 17, 2019
@effigies
Copy link
Member

Should be fine as long as we don't do pre-installs. But perhaps <0.5.0a0 is a better move.

@emdupre
Copy link
Collaborator

emdupre commented Apr 17, 2019

There's a brand new release that fixes this problem ! You could pin to nilearn >= 0.5.2

https://pypi.org/project/nilearn/

@effigies
Copy link
Member

Not sure I want to commit to >=0.5.2. There are other issues in the 0.5 series that haven't been addressed and we may need to go with <0.5.0a in the end.

@oesteban
Copy link
Member Author

Banning 0.5.0 and 0.5.1 seems just fine for now. Let's not trigger an update for all installed systems as fmriprep is indeed compatible with older versions.

@oesteban oesteban merged commit 13f088c into nipreps:master Apr 17, 2019
@oesteban oesteban deleted the ds005/fix-master branch April 17, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants