FIX: Support 4D SBRefs when generating the bold reference #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Apr 11, 2019
… SBRef conditionally before generating the reference
effigies
approved these changes
Apr 11, 2019
|
We can ask Ian to run it. Can you give him some tips on how to build a new
singularity image? Otherwise, it'll need to wait until Tuesday
…On Thu, Apr 11, 2019, 08:21 Chris Markiewicz ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Assume you have a test dataset you're checking this on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1581 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkhxjJEfuT5rh3QiT2iJ-l558PRX-WIks5vf1L0gaJpZM4co4QR>
.
|
|
I've pushed this as |
|
@IanEisenberg Are you able to build a new singularity image from a Docker image? Try: I don't know if other options are needed on your environment, but if you use other options usually, go ahead. |
|
I just confirmed this patch works out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1511. Addresses #1579 and #1463.