Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use a local docker registry instead of load/save #46

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

oesteban
Copy link
Member

In other projects we have experience optimizations of up to 30% runtime using a docker registry instead docker load/save.

@pull-assistant
Copy link

pull-assistant bot commented Dec 12, 2019

Score: 0.96

Best reviewed: commit by commit


Optimal code review plan

     MAINT: Use a local docker registry instead of load/save

     fix: handling cache of build job

     fix: dependencies

Powered by Pull Assistant. Last update 5d0fb44 ... 98c5e80. Read the comment docs.

@oesteban oesteban force-pushed the maint/optimize-circle branch from 262b356 to 5d0fb44 Compare December 13, 2019 00:09
@oesteban oesteban force-pushed the maint/optimize-circle branch from 1629e9d to 98c5e80 Compare December 13, 2019 01:03
@codecov-io
Copy link

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files          11       11           
  Lines         772      772           
  Branches      116      116           
=======================================
  Hits          422      422           
  Misses        349      349           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9952be...98c5e80. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review December 13, 2019 02:00
@oesteban
Copy link
Member Author

Working out, just need to test on master after the merge. Main build is -7 min and the smoke test -6 min (so around the expected 30%)

@oesteban oesteban merged commit 3a0341f into master Dec 13, 2019
@oesteban oesteban deleted the maint/optimize-circle branch December 13, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants