Support a storyboard or nib file. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [self didInitView]; | ||
| } | ||
|
|
||
| -(void)didInitView |
There was a problem hiding this comment.
didInitView is not suitable name for me. I think method's name must be verb. And also did~ and will~ are hook point name is taken by framework. I offer configureViews which is common name to be used in apple framework internal.
|
@ksjun Thanks to your contribution. I added one review comment. Please check it. |
|
Yes, I changed a method name. |
|
Thank you! LGTM 👍 |
ninjinkun
added a commit
that referenced
this pull request
May 6, 2014
Support a storyboard or nib file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.