Publicize web view progress constants. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good idea, thank you.
I refered WebKit's implementation. https://github.com/WebKit/webkit/blob/2a60b589f6f4e7f91a93164ad64509aeffc0b760/Source/WebCore/loader/ProgressTracker.cpp Please tell me your naming idea. |
Currently, a developer that wants to execute code when the DOM in a web
view has become interactive must write the following:
```objc
-(void)webViewProgress:(NJKWebViewProgress *)webViewProgress
updateProgress:(float)progress
{
if (progress == 0.5) { /* ... */ }
}
```
In the above sample, `0.5` is a magic number.
Eliminate the need to use magic numbers by publicizing the constants
used internally: `0.1`, `0.5`, and `0.9`. This allows users to write the
following:
```objc
if (progress == NJKInteractiveProgressValue) { /* ... */ }
```
Add an explanation of the new constants to the README.
|
I like |
|
LGTM! |
ninjinkun
added a commit
that referenced
this pull request
Apr 9, 2014
Publicize web view progress constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a developer that wants to execute code when the DOM in a web
view has become interactive must write the following:
In the above sample,
0.5is a magic number.Eliminate the need to use magic numbers by publicizing the constants
used internally:
0.1,0.5, and0.9. This allows users to write thefollowing: