Fixed a problem when using -showTabBar: in iPad started in landscape mode
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This modification has a problem, please ignore it, I forgot that the |
|
Sorry, mis clicked the close this pull request button. |
|
The new modification contains the logic based on the tabViewController only. |
| @@ -163,12 +175,12 @@ - (void)setTabBarOriginY:(CGFloat)y animated:(BOOL)animated | |||
| CGFloat toolBarHeight = frame.size.height; | |||
| CGSize viewSize = self.tabBarController.view.frame.size; | |||
| CGFloat viewHeight = UIInterfaceOrientationIsPortrait(self.interfaceOrientation) ? viewSize.height : viewSize.width; | |||
|
|
|||
| @@ -138,7 +138,19 @@ - (void)setToolbarOriginY:(CGFloat)y animated:(BOOL)animated | |||
|
|
|||
| - (void)showTabBar:(BOOL)animated | |||
| { | |||
| CGFloat viewHeight = self.tabBarController.view.frame.size.height; | |||
| /* NOTE by Tonny | |||
There was a problem hiding this comment.
I think this comment is redundant because it's caused by my implementation miss and this tabBar behaviour is known.
|
Thanks to your patch. Basically, it looks good. I added few comments. |
|
Sorry, I just removed those dev notes and white spaces. |
| CGFloat topLimit = viewHeight - toolBarHeight; | ||
| CGFloat bottomLimit = viewHeight; | ||
|
|
||
There was a problem hiding this comment.
Please remove unnecessary white spaces (but leave new line 😃 )
|
👍 Good reviewer! :p Done. |
|
LGTM 👍 |
ninjinkun
added a commit
that referenced
this pull request
Aug 19, 2014
Fixed a problem when using `-showTabBar:` in iPad started in landscape mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly possibly it's a bug in UIKit that when you access the view from the TabBarController, you got a fixed view size discarded the orientation info.