add missing null checks to public constructors #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm working on a static analysis tool that looks for missing null checks. It suggested you add these checks:
Reasons:
ActivationCache constructor: if cachePruner is null, the constructor will always throw an exception
Pipeline constructor: fs activationCache is null and subsequently Activate or Deactivate is called, it will throw an exception (because Activate and Deactive both dereference activationCache)
ActivationCacheStrategy constructor: if activationCache is null and subsequently Activate or Deactivate is called, it will throw an exception (because Activate and Deactive both dereference activationCache)
CompiledModuleLoaderPlugin constructor: if assemblyNameRetriever is null and subsequently LoadModules is called, it will throw an exception because LoadModules dereferences assemblyNameRetriever