Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type in some overloads of ResolutionExtensions.CanResolve #158

Closed
robv8r opened this issue Jan 3, 2015 · 0 comments
Closed

Comments

@robv8r
Copy link

robv8r commented Jan 3, 2015

In Ninject.Syntax.ResolutionExtensions, some overloads of the CanResolve method incorrectly return an object. These should return a bool since they all call the same private CanResolve method which returns a bool.

Also, the documentation for these methods all state that the return type (whether object or bool) is "An instance of the service." This should be "<c>True</c> if the request can be resolved; otherwise, <c>c>false<c>/c>."

scott-xu added a commit that referenced this issue Jan 4, 2015
@scott-xu scott-xu closed this as completed Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants