Skip to content

Commit

Permalink
change BatchLogRecordProcessorFactory::Create to static method, Fixed…
Browse files Browse the repository at this point in the history
… a typo in a comment
  • Loading branch information
ninghejun committed Dec 20, 2022
1 parent e7579ed commit 3d56944
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/common/global_log_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class GlobalLogHandler
OPENTELEMETRY_END_NAMESPACE

/**
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy sigletons.
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy singletons.
* To ensure that GlobalLogHandler is the first one to be initialized (and so last to be
* destroyed), it is first used inside the constructors of TraceProvider, MeterProvider
* and LoggerProvider for debug logging. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class BatchLogRecordProcessorFactory
/**
* Create a BatchLogRecordProcessor.
*/
std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
const BatchLogRecordProcessorOptions &options);
static std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
const BatchLogRecordProcessorOptions &options);
};

} // namespace logs
Expand Down

0 comments on commit 3d56944

Please sign in to comment.