matching: Consider nnkTupleConstr as tuple #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Clyybber instead, use |
|
Being more strict would be wrong, see https://github.com/nim-lang/fusion/blob/master/src/fusion/matching.nim#L1146 |
|
ok, will take your word for it :) |
haxscramper
added a commit
to haxscramper/hmisc
that referenced
this pull request
Nov 17, 2021
Considering fusion library has been completely ignored and left to rot in uncertainty I do not see any reason for me to even *try* to maintain pattern matching outside of my dependency tree - I don't want to wait of months before each my fix gets merged only to find that nobody cares enough to even tag stuff properly (which leads to reports like nim-lang/fusion#99 **even though the fix has already been merged** nim-lang/fusion#86 almost a year ago)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix on current devel, and required for nim-lang/Nim#13793