Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RFCs/symbol_alias.md #237

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jun 18, 2020

as was requested, this removes the RFC md file I just added in favor of having it as an issue #232

note that I still prefer an md file for complex RFC's like this one for those reasons:

  • it's version controlled; unlike github issues
  • makes it easier to collaborate on since it's version controlled (eg an RFC can get pull requests from others to improve/discuss it)
  • makes it easier to comment on specific points via PR's or other means (eg: the comments I got from RFC for symbol alias for https://github.com/nim-lang/Nim/pull/11992 #235; PR comments are easier to deal with than issue comments since you can comment on specific lines)

but then also Template.md should proably be removed too if we're not using md files for RFCS

@timotheecour timotheecour requested a review from Araq June 18, 2020 19:21
@Araq
Copy link
Member

Araq commented Jun 19, 2020

but then also Template.md should proably be removed too if we're not using md files for RFCS

Yes and in fact for this repository "Pull requests" should be disabled.

@Araq Araq merged commit d278ed8 into nim-lang:master Jun 19, 2020
@timotheecour timotheecour deleted the rever_rfc_alias branch June 19, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants