Const tuple unpacking #9964
Merged
Const tuple unpacking #9964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Dec 13, 2018
Araq
reviewed
Dec 13, 2018
| eat(p, tkEquals) | ||
| optInd(p, result) | ||
| addSon(result, parseExpr(p)) | ||
| indAndComment(p, result) | ||
|
|
||
| proc parseConstant(p: var TParser): PNode = | ||
| #| constant = identWithPragma (colon typeDesc)? '=' optInd expr indAndComment |
There was a problem hiding this comment.
This comment describes the grammar rule and stopped reflecting reality. ;-)
There was a problem hiding this comment.
Also the grammar needs to be written for constTuple
But since I have no idea about EBNF, I leave this to you 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6355
While this works for all the cases I tried, there may still be bugs.
Review carefully.