-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #18146; fixes #19372; disable tlsEmulation on windows; static link pthreads with mingw #21668
Conversation
3899054
to
cc36c65
Compare
I tested it by deleting |
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
@ringabout I tested it here, after this PR, but it keeps dynamically linking pthread. Tested with the gcc compilers provided by Nim. How did I test and verify that I needed "libwinpthread-1.dll"? Steps to reproduce:
When trying to run it will give an error saying that it needs "libwinpthread-1.dll". |
Looking into it |
It seems that apart from the direct use of |
Yes, it works. That's how I was able to link statically. I'm just not sure it will force static link to all the other -lLibs passed as well. Perhaps a way to add |
Here is the link parameter
It seems that |
It seems that if |
…indows; static link pthreads with mingw (nim-lang#21668) * fixes nim-lang#18146; disable tlsEmulation on windows; static link libwinthreads DLL * whatever
…indows; static link pthreads with mingw (nim-lang#21668) * fixes nim-lang#18146; disable tlsEmulation on windows; static link libwinthreads DLL * whatever
…indows; static link pthreads with mingw (nim-lang#21668) * fixes nim-lang#18146; disable tlsEmulation on windows; static link libwinthreads DLL * whatever
fixes #18146
fixes #19372