Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for bad error message with const in case statement #21182

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Dec 27, 2022

Fix the bad error message in the forum post https://forum.nim-lang.org/t/9762

@metagn metagn changed the title preliminary fix for bad error message with const fix for bad error message with const in case statement Dec 27, 2022
@Araq
Copy link
Member

Araq commented Dec 27, 2022

seems to break tests/concepts/tmatrixconcept.nim

@metagn
Copy link
Collaborator Author

metagn commented Dec 27, 2022

Fixed

@Araq Araq merged commit 5684093 into nim-lang:devel Dec 27, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 5684093

Hint: mm: orc; opt: speed; options: -d:release
165573 lines; 9.999s; 610.902MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
* preliminary fix for bad error message with const

* add test case

* fix tmatrixconcept and tmatrixlib
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* preliminary fix for bad error message with const

* add test case

* fix tmatrixconcept and tmatrixlib
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
* preliminary fix for bad error message with const

* add test case

* fix tmatrixconcept and tmatrixlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants