better procvar ambiguity errors, clean up after #20457 #20932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Nov 28, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
…ang#20932) * better procvar ambiguity errors, clean up after nim-lang#20457 fixes nim-lang#6359, fixes nim-lang#13849 * only trigger on closedsymchoice again * new approach * add manual entry for ambiguous enums too * add indent [skip ci] * move to proc
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…ang#20932) * better procvar ambiguity errors, clean up after nim-lang#20457 fixes nim-lang#6359, fixes nim-lang#13849 * only trigger on closedsymchoice again * new approach * add manual entry for ambiguous enums too * add indent [skip ci] * move to proc
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…ang#20932) * better procvar ambiguity errors, clean up after nim-lang#20457 fixes nim-lang#6359, fixes nim-lang#13849 * only trigger on closedsymchoice again * new approach * add manual entry for ambiguous enums too * add indent [skip ci] * move to proc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6359, fixes #13849, follows up #20457
#18785 is related: The error message is fixed, however there is no way to disambiguate procs in different scopes in the same module.