dom: remove X* = ref XObj [backport] #20910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Is that important? If not it might be better in a big refactor as this is backport. |
Varriount
approved these changes
Nov 29, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Nov 30, 2022
dom: remove X* = ref XObj (cherry picked from commit ce97140)
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
dom: remove X* = ref XObj
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
dom: remove X* = ref XObj
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
dom: remove X* = ref XObj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
XObjvariants are private and not used anywhere indom, so the docs of the fields for these types are hidden (hence the backport). Value type objects don't make sense for opaque JS types anyway, there is nothing wrong with just usingref objectdirectly.