render post expr blocks better #20871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work but you need to adapt a couple of tests: tests/errmsgs/twrongcolon.nim tests/arc/topt_no_cursor.nim tests/arc/topt_wasmoved_destroy_pairs.nim tests/destructor/tv2_cast.nim |
|
Fixed |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
* render post expr blocks * remove pointless diff * fix PR split mistake
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* render post expr blocks * remove pointless diff * fix PR split mistake
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* render post expr blocks * remove pointless diff * fix PR split mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #17292 "bug 5"
Original issue mentions
*a: bbut there is a common use of this syntax in the form of--define:abc. With this patch this is correctly rendered. Also multiple post expr blocks of different kinds are supported.Originally part of #20071, StmtListExpr with semicolons in that PR is not included.