issue a warning for ptr to cstring conversion[backport] #20814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Nov 12, 2022
* issue a warning for ptr to cstring conversion[backport] * add a changelog (cherry picked from commit 8e1181b)
|
I've backported this, but now 1.6 CIs are failing: https://github.com/nim-lang/Nim/runs/9447983784 |
|
That's weird that the failure didn't appear on the devel branch, but on 1.6 branch. That aside, you can try this fix => #20834 |
Yes, that did the trick. And with that backported, I think we're ready for 1.6.10RC2. But please let me know if something else should be backported. |
|
Nice, I think #20761 should be backported later when it is merged or at least part ( |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* issue a warning for ptr to cstring conversion[backport] * add a changelog
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* issue a warning for ptr to cstring conversion[backport] * add a changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both implicit and explicit (?) conversion will be warned since it is an unsafe conversion. Unsafe features should probably be restricted to
castfamily.ref #20761
here is the warning