pragma for sfCallsite instead of name check + better semantics, test #20464
Conversation
| if sfSystemModule in s.owner.flags and s.name.s in names or | ||
| s.owner.name.s == "vm" and s.name.s == "stackTrace": | ||
| incl(s.flags, sfCallsite) | ||
|
|
There was a problem hiding this comment.
What's the point of sfCallsite anyway?
There was a problem hiding this comment.
Like {.line: instantiationInfo().}, except applies to the top node of the template body, instead of recursively on nodes below it, meaning .line will wipe the info of template parameters and callsite doesn't really do anything to an indented template body. It's implemented for these procs because instantiationInfo is lower in system than where they're implemented (it has to be below arithmetics because it uses -1, but it has to be above comparisons which is the next line after arithmetics).
I can sandwich instantiationInfo between arithmetics and comparisons, or I can try to make sfCallsite recursively copy the line info while not modifying parameter info (which it should be able to do, since it's accounted for before the template is evaluated). I'm partial towards improving callsite because it's more terse than .line, maybe we can reuse ccInline with .inline to save a symbol flag spot.
Edit: Apparently .line assumes instantiationInfo() without a parameter, and applies to expressions. So the only difference is that .line overrides template parameter infos.
Not documented because it seems to be for internal use? Should also make it possible to make comparisons and setops imports, but this doesn't have to be done. I can reuse a name like `cursor` for the pragma as well, added a new name just to be safe.
6c30fde to
3ce58eb
Compare
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
…im-lang#20464) * pragma for sfCallsite instead of name check at every template definition Not documented because it seems to be for internal use? Should also make it possible to make comparisons and setops imports, but this doesn't have to be done. I can reuse a name like `cursor` for the pragma as well, added a new name just to be safe. * make sfCallsite recursive, add tests
Previously
sfCallsiteis only inferred based on template name & module at template definitions. Now there is a pragma for it namedcallsite, although another pragma name can be reused (unsure if the shim works for this though).sfCallsitealso now acts recursively, like{.line.}.Can document the pragma, but it seems to be for internal use. The difference with
{.line.}is that sincesfCallsiteacts before the template is evaluated, the substituted parameters keep their original information. The test shows this.This should also make it possible to make comparisons and setops imports, but this doesn't have to be done.