fix #13515 [backport] #20315
Merged
fix #13515 [backport] #20315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Sep 8, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Sep 19, 2022
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* fix nim-lang#13515 * only compile test * no idea why this PR is unlocking this * don't rope in symchoices * even more restrictive
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13515
Really prepareOperand's behavior of checking for nil node types is questionable, but I think this change is the most harmless for now, it's partially justified as templates resolving symbols early is unexpected.
Does not specifically need to be backported.