Add OpenSSL 3 support #19814

FedericoCeratto · 2022-05-21T15:08:24Z

Drop support for versions below 1.1.0
Move away from deprecated functions
Fixes: #19604

ghost · 2022-05-21T15:30:15Z

So are you also planning on removing LibreSSL support as it relies on OpenSSL 1.0 APIs? It's really nice that you're doing the work with bringing up OpenSSL 3, but I think dropping support for OpenSSL < 1.1.0 is not a good idea.

FedericoCeratto · 2022-05-22T13:36:41Z

@Yardanico supporting OpenSSL 3, 1.1, 1.0, 0.9 and LibreSSL, both with dynamic and static linking (and across multiple OSes) creates a combinatorial explosion of test scenarios, making it really difficult to ensure the libraries are used securely.
IMHO we should try to reduce the complexity in the wrapper. Maybe even remove a good fraction of unused procs.
See #19604 for more comments.

heinthanth

@FedericoCeratto, I'm not sure but I think, the reason of failing on mac runners is due to this ...

.github/workflows/ci_packages.yml

heinthanth · 2022-07-11T06:53:40Z

No Luck ... the same error.

I think it's due to macOS SIP. It don't pass VARIABLES starts with DYLD_ to subprocess.

DYLD_LIBRARY_PATH variables exists. But when I execute levelOne.sh that var is wiped out. So, u can't set DYLD_* variable outside and use inside script that's the main issue. Other than that, the pull request works fine!

https://stackoverflow.com/questions/35568122/why-isnt-dyld-library-path-being-propagated-here
rbenv/rbenv#962

I found those issues.

heinthanth · 2022-07-11T08:36:27Z

Here are the proofs

I've a script to run compiled nimble at bin dir. When I run that nimble, it works ( since var is passed to nimble process )
But when I run it via runNimble.sh, didn't work ( since var is wiped out ).
PS: I compiled nimble with -d:nimDebugDlOpen to debug.

FedericoCeratto · 2022-07-12T17:25:41Z

Env vars get lost might get lost in different locations in nimInternalBuildKochAndRunCI.
Even nim r foo.nim drops them.
Besides, having to add special env vars for OSX would be an annoying requirement for end users. SSL should work out of the box.

FedericoCeratto · 2022-07-31T16:15:27Z

The library import on Mac OS X is now fixed.

FedericoCeratto · 2022-08-02T16:22:17Z

@ringabout @Araq the remaining issue seems to be a timeout due to slow CI. Do you think the PR can be reviewed and merged?

ringabout · 2022-08-02T16:24:28Z

the remaining issue seems to be a timeout due to slow CI.

I restarted the failed CI.

Araq · 2022-08-03T10:13:27Z

One more attempt before I'll merge it anyway.

heinthanth · 2022-08-03T12:24:32Z

Failed CI is due to timeout, I guess. Anyway, nice work @FedericoCeratto. Congrats!

FedericoCeratto · 2022-08-03T17:42:11Z

@Araq is there any plan to make a minor release to add support for OpenSSL 3? A number of users are being impacted by this.

FedericoCeratto · 2022-08-18T20:12:12Z

@Araq finally the CI is all green :)

github-actions · 2022-08-23T20:13:27Z

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 2dcfd73

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163641 lines; 12.692s; 841.465MiB peakmem

arnetheduck · 2022-08-26T08:27:55Z

These changes break CI on macos 11 for many of our projects that previously worked without having to install additional dependencies:

Nim Compiler Version 1.7.1 [MacOSX: amd64]
Compiled at 2022-08-26
Copyright (c) 2006-2022 by Andreas Rumpf

git hash: ea44c5cfed21951feb5978b74fbc6cdb24f54ac2
active boot switches: -d:release
could not load: libcrypto.1.1.dylib
(compile with -d:nimDebugDlOpen for more information)

https://github.com/status-im/nim-web3/runs/8027875139?check_suite_focus=true

due to changes in nim-lang/Nim#19814

* switch CI to the supported versions of ubuntu and macos See: - actions/runner-images#6002 - actions/runner-images#5583 * don't continue on error for Nim 1.6 * install openssl on macos for Nim devel due to changes in nim-lang/Nim#19814

due to changes in nim-lang/Nim#19814

This reverts commit 2dcfd73.

* conservative partial revert of #19814 * fix * revert tssl * revert azure CI change * keep azure, revert version range * fully revert CI, add changelog * useOpenssl3 as separate define, .3 is a version

This reverts commit 2dcfd73.

* Revert "Add OpenSSL 3 support (#19814)" This reverts commit 2dcfd73. * openssl 3 support no longer opt in + some 1.0 support * hopefully fix * maybe fix * final attempt * actual fix hopefully

hkl615 · 2022-11-23T12:10:05Z

Hiiii

hkl615 · 2022-11-23T12:10:11Z

FedericoCeratto:openssl3

due to changes in nim-lang/Nim#19814

* switch CI to the supported version of ubuntu See actions/runner-images#6002 * don't continue on error for Nim 1.6 * install openssl on macos for Nim devel due to changes in nim-lang/Nim#19814 --------- Co-authored-by: Jacek Sieka <jacek@status.im>

* Minor refactor * Add OpenSSL 3 support Remove symbols noOpenSSLHacksq and openssl10 * Drop loading of older openssl versions * Add library path * Use only versioned libssl soname os OSX * Update .github/workflows/ci_packages.yml Co-authored-by: Hein Thant <official.heinthanth@gmail.com> * On Mac OS X CI, link OpenSSL in /usr/local/lib/ * Install OpenSSL on Mac OS X on azure pipeline * Remove DYLD_LIBRARY_PATH Co-authored-by: Hein Thant <official.heinthanth@gmail.com> Co-authored-by: Andreas Rumpf <rumpf_a@web.de> Co-authored-by: Hein Thant <official.heinthanth@gmail.com>

) * conservative partial revert of nim-lang#19814 * fix * revert tssl * revert azure CI change * keep azure, revert version range * fully revert CI, add changelog * useOpenssl3 as separate define, .3 is a version

* Revert "Add OpenSSL 3 support (nim-lang#19814)" This reverts commit 2dcfd73. * openssl 3 support no longer opt in + some 1.0 support * hopefully fix * maybe fix * final attempt * actual fix hopefully

FedericoCeratto requested review from dom96 and alaviss May 21, 2022 15:32

FedericoCeratto force-pushed the openssl3 branch from d39b6ea to 45f0ea3 Compare May 21, 2022 16:46

FedericoCeratto force-pushed the openssl3 branch from 45f0ea3 to af44714 Compare May 24, 2022 21:04

FedericoCeratto requested review from Araq and removed request for dom96 May 29, 2022 12:50

FedericoCeratto force-pushed the openssl3 branch from af44714 to a109e0d Compare June 12, 2022 17:16

FedericoCeratto requested a review from dom96 June 19, 2022 14:16

FedericoCeratto force-pushed the openssl3 branch 3 times, most recently from c9cae5e to be8b094 Compare July 1, 2022 11:35

heinthanth suggested changes Jul 11, 2022

View reviewed changes

.github/workflows/ci_packages.yml Outdated Show resolved Hide resolved

FedericoCeratto force-pushed the openssl3 branch from 2aa2ed1 to 82a4372 Compare July 30, 2022 14:39

FedericoCeratto force-pushed the openssl3 branch from 46402dc to dccf88c Compare August 2, 2022 11:04

FedericoCeratto requested review from ringabout and Varriount and removed request for dom96 August 2, 2022 16:22

Araq closed this Aug 3, 2022

Araq reopened this Aug 3, 2022

Araq merged commit 2dcfd73 into nim-lang:devel Aug 23, 2022

FedericoCeratto deleted the openssl3 branch August 25, 2022 17:55

narimiran added a commit to status-im/nim-chronos that referenced this pull request Aug 30, 2022

install openssl on macos for Nim devel

9644f48

due to changes in nim-lang/Nim#19814

narimiran added a commit to status-im/nim-stew that referenced this pull request Aug 30, 2022

install openssl on macos for Nim devel

d4f0117

due to changes in nim-lang/Nim#19814

narimiran added a commit to status-im/nim-metrics that referenced this pull request Aug 31, 2022

install openssl on macos for Nim devel

93aafd2

due to changes in nim-lang/Nim#19814

narimiran added a commit to status-im/nim-ssz-serialization that referenced this pull request Sep 2, 2022

install openssl on macos for Nim devel

5805a97

due to changes in nim-lang/Nim#19814

narimiran added a commit to status-im/nim-toml-serialization that referenced this pull request Sep 2, 2022

install openssl on macos for Nim devel

a413477

due to changes in nim-lang/Nim#19814

jangko pushed a commit to status-im/nim-toml-serialization that referenced this pull request Sep 3, 2022

install openssl on macos for Nim devel

544bc9e

due to changes in nim-lang/Nim#19814

Araq added a commit that referenced this pull request Sep 7, 2022

Revert "Add OpenSSL 3 support (#19814)"

2e7e4ff

This reverts commit 2dcfd73.

Araq mentioned this pull request Sep 7, 2022

Revert "Add OpenSSL 3 support" #20317

Closed

metagn added a commit to metagn/Nim that referenced this pull request Sep 13, 2022

conservative partial revert of nim-lang#19814

a73ff71

metagn mentioned this pull request Sep 13, 2022

partial revert and redesign of #19814, changelog #20341

Merged

metagn added a commit to metagn/Nim that referenced this pull request Oct 26, 2022

Revert "Add OpenSSL 3 support (nim-lang#19814)"

a0582f2

This reverts commit 2dcfd73.

This was referenced Oct 26, 2022

openssl 3 support no longer opt in + some 1.0 support #20668

Merged

openssl 3 support (1.6) #20669

Merged

metagn mentioned this pull request Nov 3, 2022

Support OpenSSL 3 #19604

Closed

jangko pushed a commit to status-im/nim-ssz-serialization that referenced this pull request Jan 24, 2023

install openssl on macos for Nim devel

0083e5f

due to changes in nim-lang/Nim#19814

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OpenSSL 3 support #19814

Add OpenSSL 3 support #19814

FedericoCeratto commented May 21, 2022 •

edited

Loading

ghost commented May 21, 2022

FedericoCeratto commented May 22, 2022 •

edited

Loading

heinthanth left a comment •

edited

Loading

heinthanth commented Jul 11, 2022 •

edited

Loading

heinthanth commented Jul 11, 2022 •

edited

Loading

FedericoCeratto commented Jul 12, 2022

FedericoCeratto commented Jul 31, 2022

FedericoCeratto commented Aug 2, 2022

ringabout commented Aug 2, 2022

Araq commented Aug 3, 2022

heinthanth commented Aug 3, 2022

FedericoCeratto commented Aug 3, 2022

FedericoCeratto commented Aug 18, 2022

github-actions bot commented Aug 23, 2022

arnetheduck commented Aug 26, 2022

hkl615 commented Nov 23, 2022

hkl615 commented Nov 23, 2022

Add OpenSSL 3 support #19814

Add OpenSSL 3 support #19814

Conversation

FedericoCeratto commented May 21, 2022 • edited Loading

ghost commented May 21, 2022

FedericoCeratto commented May 22, 2022 • edited Loading

heinthanth left a comment • edited Loading

Choose a reason for hiding this comment

heinthanth commented Jul 11, 2022 • edited Loading

heinthanth commented Jul 11, 2022 • edited Loading

FedericoCeratto commented Jul 12, 2022

FedericoCeratto commented Jul 31, 2022

FedericoCeratto commented Aug 2, 2022

ringabout commented Aug 2, 2022

Araq commented Aug 3, 2022

heinthanth commented Aug 3, 2022

FedericoCeratto commented Aug 3, 2022

FedericoCeratto commented Aug 18, 2022

github-actions bot commented Aug 23, 2022

arnetheduck commented Aug 26, 2022

hkl615 commented Nov 23, 2022

hkl615 commented Nov 23, 2022

FedericoCeratto commented May 21, 2022 •

edited

Loading

FedericoCeratto commented May 22, 2022 •

edited

Loading

heinthanth left a comment •

edited

Loading

heinthanth commented Jul 11, 2022 •

edited

Loading

heinthanth commented Jul 11, 2022 •

edited

Loading