-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimIdentNormalize removes spaces #18709
Conversation
lib/pure/strutils.nim
Outdated
runnableExamples: | ||
doAssert nimIdentNormalize("Foo_bar") == "Foobar" | ||
doAssert nimIdentNormalize("Foo Bar") == "Foobar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dubios. The compiler only does it for backticks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, agree, changed that.
also rm backticks themseves
I still don't see the point, what's the benefit of this (it is a breaking change btw)? |
For more correct treatment of backticked identifiers in #18642 . The use cases are minor: so that a user could input RST link |
Make the docgen use its own idea of |
ok, you can close it, but note that it's not a breaking change anymore, it's a separate proc |
BTW i don't admit that it's "my own idea". I was amazed myself when realized that spaces between backticks are not significant: proc fooBar(x: int): int = 3*x
echo $`foo bar`(3) |
Why not move it to the docgen? |
Just to conform to the compiler behavior.