add -d:nimLegacyNoHashRef for a transition period which avoids defining hash(ref) #17858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
743be21 to
0e5a03b
Compare
|
This does not resolve the issue really, of breaking working code in minor releases - the new hash function must be opt-in in order for that to happen - |
|
Also, this creates two dialects of a critical library feature, again making it impossible to use practically in applications - the only way to compatibly introduce this feature is to introduce a separate module with the new hash function, such that the change is opt-in and local. |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #17731 (comment)
affected users can opt-out with
-d:nimLegacyNoHashReffor a transition period (say, in their user or project config)