fix #15955: avoid duplicate symbol errors with --app:staticlib
by using weak symbols
#16945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15955 by introducing
-d:nimLinkerWeakSymbols
which generates weak symbols via__attribute__((weak))
, see testsnote
currently fails on windows: see https://dev.azure.com/nim-lang/255dfe86-e590-40bb-a8a2-3c0295ebdeb1/_apis/build/builds/12851/logs/89
__attribute__((weak))
and static linking__attribute__((weak))
, with either__declspec(selectany)
or#pragma comment(linker, "/alternatename:_pWeakValue=_pDefaultWeakValue")
/ALTERNATENAME linker switch