Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15955: avoid duplicate symbol errors with --app:staticlib by using weak symbols #16945

Closed
wants to merge 7 commits into from

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 6, 2021

fix #15955 by introducing -d:nimLinkerWeakSymbols which generates weak symbols via __attribute__((weak)), see tests

note

currently fails on windows: see https://dev.azure.com/nim-lang/255dfe86-e590-40bb-a8a2-3c0295ebdeb1/_apis/build/builds/12851/logs/89

@timotheecour timotheecour changed the title fix #15955: --app:staticlib -d:nimLinkerWeakSymbols allows using weak symbols fix #15955: avoid duplicate symbol errors with --app:staticlib by using weak symbols Feb 6, 2021
@Araq
Copy link
Member

Araq commented Dec 10, 2021

Succeeded by #19235.

@Araq Araq closed this Dec 10, 2021
narimiran pushed a commit that referenced this pull request Dec 10, 2021
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static linking with a .lib file not working
2 participants