Add Punctuation characters set #16708
Conversation
Sometimes is useful to check or strip punctuation.
|
I also add the |
| @@ -89,6 +89,9 @@ const | |||
| ## All the characters that count as whitespace (space, tab, vertical tab, | |||
| ## carriage return, new line, form feed). | |||
|
|
|||
| Punctuation* = {'!', '"', '#', '$', '%', '&', '\'', '(', ')', '*', '+', ',', '-', '.', '/', ':', ';', '<', '=', '>', '?', '@', '[', '\\', ']', '^', '_', '`', '{', '|', '}', '~'} | |||
| ## All the characters that count as punctuation (comma, colon, dash etc). | |||
|
|
|||
There was a problem hiding this comment.
optional: how about also adding Printable?
refs https://docs.python.org/3/library/string.html?highlight=string#string.printable
could also be another PR
tests/stdlib/tstrutils.nim
Outdated
| doAssert isPunctAscii(':') | ||
| doAssert isPunctAscii(';') | ||
| doAssert(not isPunctAscii('A')) | ||
|
|
There was a problem hiding this comment.
and add from std/setutils import toSet on top
| # check this matches https://en.cppreference.com/w/c/string/byte/ispunct | |
| doAssert "!\"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~".toSet == Punctuation | |
lib/pure/strutils.nim
Outdated
| @@ -158,6 +161,14 @@ func isSpaceAscii*(c: char): bool {.rtl, extern: "nsuIsSpaceAsciiChar".} = | |||
| doAssert isSpaceAscii('\t') == true | |||
| return c in Whitespace | |||
|
|
|||
| func isPunctAscii*(c: char): bool {.rtl, extern: "nsuIsPunctAsciiChar".} = | |||
There was a problem hiding this comment.
i don't think we need this proc, c in Punctuation seems good enough
There was a problem hiding this comment.
Ok. I'll remove it.
|
Seems more dangerous than useful, sorry. What does count as "punctuation" depends too much on the concrete use case. If you follow some spec, better write the set down yourself rather than relying on strutils's definition of it. And if you don't have a spec and use strutils.Punctuation, either we can never change its definition ("improve it because then it's consistent with Python...") or we break your code when we do. |
|
=> followup #18193 (comment) |
Sometimes is useful to check or strip punctuation.