[backport 1.0] add backend support for js bigint #16606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timotheecour
commented
Jan 6, 2021
•
- needed for Add js BigInts #16409 to give jsBigInts sane semantics
- backport all the way to 1.0.x, so that std/jsbigints can work for old nim (trivial and innocuous backend change)
- see test which shows a trimmed down implementation just to show the semantics (the full library implementation is done in Add js BigInts #16409 and should use this simple replacement:
Merged
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* add backend support for js bigint * cleanup * add tests * add -d:nimHasJsBigIntBackend * cleanup * more tests
narimiran
pushed a commit
that referenced
this pull request
Feb 1, 2021
* add backend support for js bigint * cleanup * add tests * add -d:nimHasJsBigIntBackend * cleanup * more tests (cherry picked from commit 025ca66)
narimiran
pushed a commit
that referenced
this pull request
Feb 1, 2021
* add backend support for js bigint * cleanup * add tests * add -d:nimHasJsBigIntBackend * cleanup * more tests (cherry picked from commit 025ca66)
narimiran
pushed a commit
that referenced
this pull request
Feb 1, 2021
* add backend support for js bigint * cleanup * add tests * add -d:nimHasJsBigIntBackend * cleanup * more tests (cherry picked from commit 025ca66)
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* add backend support for js bigint * cleanup * add tests * add -d:nimHasJsBigIntBackend * cleanup * more tests
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.