Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax (RST) fix Internals of the Compiler #16341

Merged

Conversation

saem
Copy link
Contributor

@saem saem commented Dec 13, 2020

'Rebuilding the Compiler' and a few other sections required syntax fixes:

  • new lines before and after lists to fix rendering
  • use internal reference instead of Markdown style link

doc/intern.rst Outdated Show resolved Hide resolved
@juancarlospaco
Copy link
Collaborator

Do not double-backtick everything, Nim supports RST and MD mixed, so is OK to have single backtick.

@saem
Copy link
Contributor Author

saem commented Dec 14, 2020

OK, I'll unwind the backticks.

However, it doesn't render well for those simply viewing this on github without going through any transform.

'Rebuilding the Compiler' and a few other sections required syntax fixes:
* new lines before and after lists to fix rendering
* use internal reference instead of Markdown style link
@saem saem force-pushed the saem-minor-doc-formatting-internals-compiler branch from 28d101e to 5581798 Compare December 14, 2020 00:38
@saem
Copy link
Contributor Author

saem commented Dec 14, 2020

Updated so I no longer use double backticks, built it locally and retested the links in the generated docs -- they seem to work.

@timotheecour
Copy link
Member

timotheecour commented Dec 14, 2020

However, it doesn't render well for those simply viewing this on github without going through any transform.

I understand; note that this argument is currently moot because https://github.com/nim-lang/Nim/blob/devel/doc/manual.rst doesn't even render well already (github doesn't interpret it correctly; unlike https://github.com/nim-lang/Nim/blob/devel/doc/intern.rst), as reported in #4864 (comment); and I'd rather not have 2 separate syntaxes for docs in nim vs docs in rst.

4 solutions:

using our own flavor of rst (or md) has significant advantages when it comes to using our own tools to render it (allows more features for docgen) but comes at price of it not working so well when rendered with other tools. I think it's an acceptable tradeoff.

@saem
Copy link
Contributor Author

saem commented Dec 14, 2020

However, it doesn't render well for those simply viewing this on github without going through any transform.

I understand; note that this argument is currently moot because https://github.com/nim-lang/Nim/blob/devel/doc/manual.rst doesn't even render well already (github doesn't interpret it correctly; unlike https://github.com/nim-lang/Nim/blob/devel/doc/intern.rst); and I'd rather not have 2 separate syntaxes for docs in nim vs docs in rst.
...

Thanks for the insight @timotheecour.

@Araq Araq merged commit 9ef7c01 into nim-lang:devel Dec 15, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
'Rebuilding the Compiler' and a few other sections required syntax fixes:
* new lines before and after lists to fix rendering
* use internal reference instead of Markdown style link
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
'Rebuilding the Compiler' and a few other sections required syntax fixes:
* new lines before and after lists to fix rendering
* use internal reference instead of Markdown style link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants