-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax (RST) fix Internals of the Compiler #16341
Syntax (RST) fix Internals of the Compiler #16341
Conversation
Do not double-backtick everything, Nim supports RST and MD mixed, so is OK to have single backtick. |
OK, I'll unwind the backticks. However, it doesn't render well for those simply viewing this on github without going through any transform. |
'Rebuilding the Compiler' and a few other sections required syntax fixes: * new lines before and after lists to fix rendering * use internal reference instead of Markdown style link
28d101e
to
5581798
Compare
Updated so I no longer use double backticks, built it locally and retested the links in the generated docs -- they seem to work. |
I understand; note that this argument is currently moot because https://github.com/nim-lang/Nim/blob/devel/doc/manual.rst doesn't even render well already (github doesn't interpret it correctly; unlike https://github.com/nim-lang/Nim/blob/devel/doc/intern.rst), as reported in #4864 (comment); and I'd rather not have 2 separate syntaxes for docs in nim vs docs in rst. 4 solutions:
using our own flavor of rst (or md) has significant advantages when it comes to using our own tools to render it (allows more features for docgen) but comes at price of it not working so well when rendered with other tools. I think it's an acceptable tradeoff. |
Thanks for the insight @timotheecour. |
'Rebuilding the Compiler' and a few other sections required syntax fixes: * new lines before and after lists to fix rendering * use internal reference instead of Markdown style link
'Rebuilding the Compiler' and a few other sections required syntax fixes: * new lines before and after lists to fix rendering * use internal reference instead of Markdown style link
'Rebuilding the Compiler' and a few other sections required syntax fixes: