Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #14369 improve docs for importcpp exceptions #14391

Merged
merged 2 commits into from
May 18, 2020
Merged

refs #14369 improve docs for importcpp exceptions #14391

merged 2 commits into from
May 18, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented May 18, 2020 •
edited
Loading

  • made snippet runnable
  • more comprehensive example to help the next person trying to figure out how to properly deal with C++ exceptions (example in existing docs really didn't help much)
  • used suggestions from @cooldome in 5 bugs with importcpp exceptions #14369

cooldome
cooldome reviewed May 18, 2020
View reviewed changes
@cooldome cooldome merged commit 2627e1e into nim-lang:devel May 18, 2020
@timotheecour timotheecour deleted the pr_doc_importcpp_exceptions branch May 18, 2020 22:22
EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
@timotheecour @EchoPouet
refs nim-lang#14369 improve docs for importcpp exceptions (nim-lang#1…
980c569 
…4391)

* refs nim-lang#14369 improve docs for importcpp exceptions

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooldome cooldome cooldome left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timotheecour @cooldome