$(a: float)
now works consistently in nim js, avoiding printing floats as ints
#14134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Araq
$(a: float)
now works more consistently and matches behavior of c, vm targetsit would be nice to merge
$
now works for unsigned intergers withnim js
#14122 before this PR so I can avoid creating a new tests/js/tdollar_float.nimonce this is green-lighted but before merge, I'll use the single argument
applyFormat
in jsgen (as I did for mFloatToStr) everywhere appropriate to make code DRYafter PR
I'm thinking to introduce a compiler flag (eg
--ecmascript:es5
) to let users choose which js version they want to target. TheNumber.isInteger
I'm using in this PR is available on all browsers but not on IE, but there is a polyfill we can easily introduce for that, say instd/jspolyfills
. The workaround implementation should be used or not depending on the desired js version in--ecmascript
;BigInt
could for example be introduced forint
for--ecmascript:es2020
ci failures unrelated