Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated procs from std/times #14129

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

GULPF
Copy link
Member

@GULPF GULPF commented Apr 26, 2020

  • Removed times procs that has been deprected since v0.18 and v0.19. I kept toSeconds and toGMTime because they are used in Nim in Action.
  • Normalized the deprecation messages.

@narimiran
Copy link
Member

FWIW, I'm working on much more thorough removal of deprecated stuff in the stdlib, which includes cleanup of times.nim too.

Once it is ready and submitted as PR, if you want I can ping you so you can give your opinion about stuff I removed in times.nim.

@GULPF
Copy link
Member Author

GULPF commented Apr 27, 2020

@narimiran OK, should I close this PR or can it be merged anyway? It also cleans up the deprecation messages a bit (currently the generated docs shows two deprecation messages for some procs).

@narimiran
Copy link
Member

OK, should I close this PR or can it be merged anyway?

Let me merge this, and I'll rebase my PR.

@narimiran narimiran merged commit 664cb2c into nim-lang:devel Apr 27, 2020
EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants